On 2017-05-21 12:47, Jonathan Cameron wrote: > On 17/05/17 16:28, Jan Kiszka wrote: >> This is an upstream port of an IIO driver for the TI ADC108S102 and >> ADC128S102. The former can be found on the Intel Galileo Gen2 and the >> Siemens SIMATIC IOT2000. For those boards, ACPI-based enumeration is >> included. >> >> Due to the lack of regulators under ACPI, we hard-code the voltage >> provided to the VA pin of the ADC to 5 V, the value used on Galileo and >> IOT2000. For DT usage, the regulator "vref-supply" provides this >> information. Note that DT usage has not been tested. >> >> Original author: Bogdan Pricop <bogdan.pri...@emutex.com> >> Ported from Intel Galileo Gen2 BSP to Intel Yocto kernel: >> Todor Minchev <to...@minchev.co.uk>. >> >> Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> > Still an issue wrt to it being obviously correct in the ordering in probe > and remove. > > As a reviewer I want to be able to run through each step in probe and > compare with remove to ensure they occur in the opposite order and > reverse all the steps in probe. Where ever it deviates from that I have > to think about it and we all know the last thing a reviewer with a big > backlog of patches wants to do is to think hard ;) > > Anyhow, I've fixed up and applied to the togreg branch of iio.git and > pushed out as testing for the autobuilders to play with it. > > Please check I haven't made a mess of it.
Forgot to push? Not finding it in togreg, which is 5 days old. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux
