On Tue, May 23, 2017 at 12:48:53AM -0700, David Carrillo-Cisneros wrote:
SNIP
> + for_each_set_bit(feat, header->adds_features, HEADER_FEAT_BITS) {
> + if (!feat_ops[feat].has_record) {
> + pr_debug("No record header feature for header :%d\n",
> feat);
> + continue;
> + }
> +
> + fdd.offset = sizeof(*fe);
> +
> + ret = feat_ops[feat].write(&fdd, evlist);
> + if (ret || fdd.offset <= (ssize_t)sizeof(*fe)) {
> + pr_debug("Error writing feature\n");
> + continue;
> + }
> +
> + /* fdd.buf may have changed due to realloc in do_write() */
> + fe = fdd.buf;
> + memset(fe, 0, sizeof(*fe));
no need to wipe it out if you set all the members just below
(apart from header.misc, which is not used)
jirka
