David Miller <da...@davemloft.net> : > From: Joshua Emele <jem...@gmail.com> > Date: Wed, 24 May 2017 15:43:18 -0700 [...] > > The sky2_hw_down uses sky2_tx_complete to free pending frames stuck in > > the HW queue. Because sky2_hw_down can be called from a process context, > > the call to u64_stats_update_begin can result in deadlock. > > > > Because the statistics do not require update as part of the sky2_hw_down > > sequence, prevent the update to avoid the deadlock. > > I disagree. Taking the interface down should cause events in the > statistics to be lost. > > You're going to have to find a way to fix this without eliding > the stats increments.
NAPI processing is already disabled at this stage in the device close() path (and sky2_netpoll() uses napi_schedule). It's possible to add a conditionnal bh or irq disabling instruction to silent the warning but it should not be needed at all. -- Ueimor
