On Wed, May 24, 2017 at 6:18 PM, Philipp Zabel <p.za...@pengutronix.de> wrote: > Hi Joel, > > On Wed, 2017-05-24 at 14:53 +1000, Joel Stanley wrote: >> @@ -132,6 +134,18 @@ static int of_platform_serial_setup(struct >> platform_device *ofdev, >> } >> } >> >> + info->rst = devm_reset_control_get_optional(&ofdev->dev, NULL); > > Please use devm_reset_control_get_optional_shared instead. > > This looks like shared (clock-like) reset use, where you just have to > make sure that the reset is deasserted while the module is in use, but > you don't care whether it is actually asserted all the time otherwise.
Thanks for the review. The new reset API is much nicer, and it worked for me once I realised the changes came in for 4.11 (my test setup is based on 4.10). Cheers, Joel
