On Thu, May 25, 2017 at 11:33 AM, Bartosz Golaszewski <b...@bgdev.pl> wrote: > The comment in linux/gpio/driver.h says: > > @get_direction: returns direction for signal "offset", 0=out, 1=in > > We got those switched at some point. Fix the values.
Shouldn't it have a Fixes tag? > > Signed-off-by: Bartosz Golaszewski <b...@bgdev.pl> > --- > drivers/gpio/gpio-mockup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c > index c6dadac..c18d011 100644 > --- a/drivers/gpio/gpio-mockup.c > +++ b/drivers/gpio/gpio-mockup.c > @@ -29,8 +29,8 @@ > #define GPIO_MOCKUP_MAX_GC 10 > > enum { > - DIR_IN = 0, > - DIR_OUT, > + DIR_OUT = 0, > + DIR_IN = 1, > }; > > /* > -- > 2.9.3 > -- With Best Regards, Andy Shevchenko