On Sun, May 21, 2017 at 12:44:03PM +0200, H. Nikolaus Schaller wrote:
> Add driver for Wi2Wi W2SG0004/84 GPS module connected through uart.
>
> Use serdev API hooks to monitor and forward the UART traffic to /dev/BTn
> and turn on/off the module. It also detects if the module is turned on (sends
> data)
> but should be off, e.g. if it was already turned on during boot or
> power-on-reset.
>
> Additionally, rfkill block/unblock can be used to control an external LNA
> (and power down the module if not needed).
>
> The driver concept is based on code developed by NeilBrown <ne...@suse.de>
> but simplified and adapted to use the new serdev API introduced in 4.11.
>
> Signed-off-by: H. Nikolaus Schaller <h...@goldelico.com>
> ---
> .../devicetree/bindings/misc/wi2wi,w2sg0004.txt | 20 +
> .../devicetree/bindings/vendor-prefixes.txt | 1 +
Please split binding patches.
> drivers/misc/Kconfig | 16 +
> drivers/misc/Makefile | 1 +
> drivers/misc/w2sg0004.c | 646
> +++++++++++++++++++++
> include/linux/w2sg0004.h | 27 +
> 6 files changed, 711 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/misc/wi2wi,w2sg0004.txt
> create mode 100644 drivers/misc/w2sg0004.c
> create mode 100644 include/linux/w2sg0004.h
>
> diff --git a/Documentation/devicetree/bindings/misc/wi2wi,w2sg0004.txt
> b/Documentation/devicetree/bindings/misc/wi2wi,w2sg0004.txt
> new file mode 100644
> index 000000000000..b7125c7a598c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/wi2wi,w2sg0004.txt
> @@ -0,0 +1,20 @@
> +Wi2Wi GPS module connected through UART
> +
> +Should be a subnode of the SoC UART it is connected to (serdev).
> +
> +Required properties:
> +- compatible: wi2wi,w2sg0004 or wi2wi,w2sg0084
Reformat to one per line.
> +- on-off-gpio: the GPIO that controls the module's on-off toggle input
Does enable-gpios or powerdown-gpios work as those are semi-standard
names. Also, need to state the active state.
> +
> +Optional properties:
> +- lna-suppy: an (optional) LNA regulator that is enabled together with the
> GPS receiver
typo
> +
> +Example:
> +
> +&uart2 {
> + gps: w2sg0004 {
w2sg0004: gps {
The node name should be generic. The label can be whatever you like.
> + compatible = "wi2wi,w2sg0004";
> + lna-supply = <&vsim>; /* LNA regulator */
> + on-off-gpios = <&gpio5 17 GPIO_ACTIVE_HIGH>; /* GPIO_145:
> trigger for turning on/off w2sg0004 */
> + };
> +};
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
> b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index c03d20140366..c56b3181b266 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -345,6 +345,7 @@ voipac Voipac Technologies s.r.o.
> wd Western Digital Corp.
> wetek WeTek Electronics, limited.
> wexler Wexler
> +wi2wi Wi2Wi, Inc.
> winbond Winbond Electronics corp.
> winstar Winstar Display Corp.
> wlf Wolfson Microelectronics
