Hi Arnd,
On Thu, May 25, 2017 at 11:02:22PM +0200, Arnd Bergmann wrote:
> On Sat, May 13, 2017 at 9:29 AM, Dong Aisheng <aisheng.d...@nxp.com> wrote:
>
> > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> > index 3356ab8..03dfd6a 100644
> > --- a/drivers/clocksource/Kconfig
> > +++ b/drivers/clocksource/Kconfig
> > @@ -590,6 +590,11 @@ config CLKSRC_IMX_GPT
> > depends on ARM && CLKDEV_LOOKUP
> > select CLKSRC_MMIO
> >
> > +config CLKSRC_IMX_TPM
> > + bool "Clocksource using i.MX TPM" if COMPILE_TEST
> > + depends on ARM && CLKDEV_LOOKUP && GENERIC_CLOCKEVENTS
> > + select CLKSRC_MMIO
> > +
>
> This needs a help text
>
Got it
>
> > +static inline void tpm_timer_disable(void)
> > +{
> > + unsigned int val;
> > +
> > + /* channel disable */
> > + val = __raw_readl(timer_base + TPM_C0SC);
> > + val &= ~(TPM_C0SC_MODE_MASK | TPM_C0SC_CHIE);
> > + __raw_writel(val, timer_base + TPM_C0SC);
> > +}
>
> __raw_readl/__raw_writel is broken on big-endian kernels, please
> use readl/writel instead.
>
That's true.
Thanks for the kind reminder.
Regards
Dong Aisheng
> Arnd
