On Mon, May 29, 2017 at 07:45:05PM -0700, Dmitry Torokhov wrote: > On Sat, May 27, 2017 at 11:40:52AM -0700, Andy Lutomirski wrote: > > On Sat, May 27, 2017 at 9:17 AM, Dmitry Torokhov > > <[email protected]> wrote: > > > On May 27, 2017 9:04:38 AM PDT, Andy Lutomirski <[email protected]> wrote: > > >>On Sat, May 27, 2017 at 3:50 AM, Pali Rohár <[email protected]> > > >>wrote: > > >>> On Saturday 27 May 2017 07:31:30 Darren Hart wrote: > > >>>> - dell_wmi_input_dev->name = "Dell WMI hotkeys"; > > >>>> - dell_wmi_input_dev->phys = "wmi/input0"; > > >>>> - dell_wmi_input_dev->id.bustype = BUS_HOST; > > >>>> + priv->input_dev->name = "Dell WMI hotkeys"; > > >>>> + priv->input_dev->id.bustype = BUS_HOST; > > >>> > > >>> Is not there BUS_WMI, or something like that? (Just asking) > > >>> > > >> > > >>Jiri and/or Dmitry, what is bustype for, anyway? > > > > > > The bus type could be used to help further identifying device if it used > > > same vendor/product for spi and i2c, for example, but there are not many > > > if them. I'm not sure if anyone actually makes decisions based on it, but > > > it is part of abi now. > > > > > >>I suppose we could add BUS_PLATFORM. > > > > > > What would be the difference from BUS_HOST? > > > > > > > If BUS_HOST means that the device is part of the host as opposed to > > being plugged in, then it seems entirely reasonable. > > Yes, it basically means platform-specific interface. >
I'm going to leave this as BUS_HOST then. Thanks everyone. -- Darren Hart VMware Open Source Technology Center
