On Mon, Apr 09, 2007 at 10:08:47PM +0900, Akinobu Mita wrote:
> kmem_cache_create() for slob doesn't handle SLAB_PANIC.
>
> Cc: Matt Mackall <[EMAIL PROTECTED]>
> Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
>
> ---
> mm/slob.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> Index: 2.6-mm/mm/slob.c
> ===================================================================
> --- 2.6-mm.orig/mm/slob.c
> +++ 2.6-mm/mm/slob.c
> @@ -298,6 +298,9 @@ struct kmem_cache *kmem_cache_create(con
> c->align = (flags & SLAB_MUST_HWCACHE_ALIGN) ? SLOB_ALIGN : 0;
> if (c->align < align)
> c->align = align;
> + } else {
> + if (flags & SLAB_PANIC)
> + panic("Cannot create slab cache %s\n", name);
> }
I think this would be more canonical:
} else if (..)
panic();
But otherwise,
Signed-off-by: Matt Mackall <[EMAIL PROTECTED]>
--
Mathematics is the supreme nostalgia of our time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
