On Tue, 06 Jun 2017 02:03:51 PDT (-0700), Arnd Bergmann wrote: > On Tue, Jun 6, 2017 at 6:56 AM, Palmer Dabbelt <pal...@dabbelt.com> wrote: >> On Thu, 25 May 2017 12:51:54 PDT (-0700), Arnd Bergmann wrote: >>> On Thu, May 25, 2017 at 3:59 AM, Palmer Dabbelt <pal...@dabbelt.com> wrote: >>>> On Mon, 22 May 2017 19:11:35 PDT (-0700), o...@lixom.net wrote: >>> >>>> * Definitions like ARCH_HAS_SETUP_ADDITIONAL_PAGES, these are also >>>> present in >>>> other architectures. >>> >>> What is the warning here? I would assume that you should leave this >>> unchanged as well. >> >> ERROR: #define of 'ARCH_HAS_SETUP_ADDITIONAL_PAGES' is wrong - use Kconfig >> variables or standard guards instead >> #2533: FILE: arch/riscv/include/asm/elf.h:79: >> +#define ARCH_HAS_SETUP_ADDITIONAL_PAGES > > Ok, you can definitely ignore this one. The warning is meant to prevent adding > new macros like that, but the macro already exists in the other architectures, > and I see no point in converting them all into a CONFIG_ symbol.
Sounds good.
