From: Vivien Didelot <vivien.dide...@savoirfairelinux.com> Date: Tue, 6 Jun 2017 16:56:29 -0400
> @@ -166,6 +166,9 @@ static int dsa_switch_vlan_add(struct dsa_switch *ds, > bitmap_zero(members, ds->num_ports); > if (ds->index == info->sw_index) > set_bit(info->port, members); > + for (port = 0; port < ds->num_ports; ++port) > + if (dsa_is_cpu_port(ds, port) || dsa_is_dsa_port(ds, port)) > + set_bit(port, members); Please use the more canonical "x++" post-increment in the for() statement. Thank you.