> -----Original Message----- > From: David Miller [mailto:[EMAIL PROTECTED] > Sent: Monday, April 09, 2007 1:47 PM > To: Waskiewicz Jr, Peter P > Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; > [EMAIL PROTECTED]; cramerj; Kok, Auke-jan H; Leech, Christopher > Subject: Re: [PATCH 2/2] NET: Multiqueue network device support. > > From: "Waskiewicz Jr, Peter P" <[EMAIL PROTECTED]> > Date: Mon, 9 Apr 2007 13:43:11 -0700 > > > True, but the assignment for "dev" above also casts this void * to > > struct net_device *: > > > > dev = (struct net_device *) > > (((long)p + NETDEV_ALIGN_CONST) & > ~NETDEV_ALIGN_CONST); > > dev->padded = (char *)dev - (char *)p; > > > > Shall I remove my cast? > > I think so. Casts tend to be red flags during patch review, > so don't add them when not necessary and let's remove the > unnecessary ones too.
Will do. On a side note, I don't see my patches landing on vger again. Did they get munched, or is majordomo lagging a bit? Thanks, -PJ Waskiewicz - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
