On Thu, 25 May 2017 13:03:11 +0100 Ian Abbott <abbo...@mev.co.uk> wrote:
> The declaration of `__warn()` has `struct pt_regs *regs` as one of its > parameters. This can result in compiler warnings if `struct regs` is > not already declared. Add an empty declaration of `struct pt_regs` to > avoid the warnings. > Not sure if this has been pulled already or not, but I have a small nit. > Signed-off-by: Ian Abbott <abbo...@mev.co.uk> > Cc: Arnd Bergmann <a...@arndb.de> > Acked-by: Arnd Bergmann <a...@arndb.de> > Acked-by: Michal Nazarewicz <min...@mina86.com> > --- > v3: Actually, there was no v1 or v2. I called this v3 to match the > series. > v4: Corrected 'Acked-by:' line in patch description. > v5: Added Acked-by for Michal Nazarewicz. > --- > include/asm-generic/bug.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h > index d6f4aed479a1..87191357d303 100644 > --- a/include/asm-generic/bug.h > +++ b/include/asm-generic/bug.h > @@ -97,6 +97,7 @@ extern void warn_slowpath_null(const char *file, const int > line); > > /* used internally by panic.c */ > struct warn_args; > +struct pt_regs; Probably be better to move pt_regs above the comment. For one, it is used before warn_args in the function below. Two, it's not defined internally by panic.c like warn_args is. -- Steve > > void __warn(const char *file, int line, void *caller, unsigned taint, > struct pt_regs *regs, struct warn_args *args);
