On Thu, Jun 8, 2017 at 3:32 PM, Enric Balletbo Serra
<[email protected]> wrote:
> Hi Keerthy:
>
> 2017-06-08 12:46 GMT+02:00 Keerthy <[email protected]>:
>> Currently the driver boots only via device tree hence add a
>> dependency on CONFIG_OF. This leaves with a bunch of unused code
>> so clean that up.
>>
>> Signed-off-by: Keerthy <[email protected]>
>
[snip]
>>
>> config MFD_TPS65217
>> tristate "TI TPS65217 Power Management / White LED chips"
>> - depends on I2C
>> + depends on I2C && OF
>
> I think you should append || COMPILE_TEST here.
>
For me it should be a separate patch, it's nice to have COMPILE_TEST
but not related to this change IMHO.
>>
>> -static const struct i2c_device_id tps65217_id_table[] = {
>> - {"tps65217", TPS65217},
>> - { /* sentinel */ }
>> -};
>> -MODULE_DEVICE_TABLE(i2c, tps65217_id_table);
Unfortunately you can't get rid of this table (yet) since the I2C
subsystem always reports a MODALIAS of the form "i2c:tps65217" even
when the devices have been registered via OF. There are only a couple
of drivers more to clean-up and then I'll post a patch that fixes the
I2C core to report a proper OF modalias. But for now, removing will
mean that module autoload will be broken for this driver.
Best regards,
Javier
