Greg Kroah-Hartman <[email protected]> writes: > On Thu, Jun 08, 2017 at 11:12:10PM +1000, Michael Ellerman wrote: >> Greg Kroah-Hartman <[email protected]> writes: >> >> > The dev_attrs field has long been "depreciated" and is finally being >> > removed, so move the driver to use the "correct" dev_groups field >> > instead for struct bus_type. >> > >> > Cc: Benjamin Herrenschmidt <[email protected]> >> > Cc: Paul Mackerras <[email protected]> >> > Cc: Michael Ellerman <[email protected]> >> > Cc: Vineet Gupta <[email protected]> >> > Cc: Bart Van Assche <[email protected]> >> > Cc: Robin Murphy <[email protected]> >> > Cc: Joerg Roedel <[email protected]> >> > Cc: Johan Hovold <[email protected]> >> > Cc: Alexey Kardashevskiy <[email protected]> >> > Cc: Krzysztof Kozlowski <[email protected]> >> > Cc: <[email protected]> >> > Signed-off-by: Greg Kroah-Hartman <[email protected]> >> > --- >> > arch/powerpc/platforms/pseries/vio.c | 37 >> > +++++++++++++++++++++--------------- >> > 1 file changed, 22 insertions(+), 15 deletions(-) >> >> This one needed a bit more work to get building, the incremental diff is >> below. We need a forward declaration of name, devspec and modalias, >> which is a bit weird, but that's how the code is currently structured. >> And there's dev and bus attributes with the same name, so that needed an >> added "bus". >> >> I booted v2 of patch 10 and this one and everything looks identical to >> upstream. > > Ah, many thanks, this was on my todo list to fix up today. > > But you renamed the sysfs files when you added "bus" to the function > names, are you sure you want to do that? I don't mind, but if you > happen to have userspace tools that look at those files, they just broke > :(
Ugh crap, no that won't work. I didn't see it when I tested because my machine doesn't have the CMO feature enabled. I guess we have to open code some of the BUS_ATTR_RO() etc. so we can avoid the name clash. I'll try and get it fixed later today. cheers
