On 05/29/2017 04:25 PM, Michael Ellerman wrote: > Anshuman Khandual <khand...@linux.vnet.ibm.com> writes: >> >> So the question is are we willing to do all these changes across >> the tree to achieve common definitions of KB, MB, GB, TB in the >> kernel ? Is it worth ? > > No I don't think it's worth the churn. > > But have you looked at using the "proper" names, ie. KiB, MiB, GiB? > > AFAICS the only clash is: > > drivers/mtd/ssfdc.c:#define KiB(x) ( (x) * 1024L ) > drivers/mtd/ssfdc.c:#define MiB(x) ( KiB(x) * 1024L ) > > Which would be easy to convert.
Sure, will take a look into generalizing KiB/MiB/GiB instead of current proposal for KB/MB/GB.
