Hi Hans, > -----Original Message----- > From: Hans de Goede [mailto:hdego...@redhat.com] > Sent: Tuesday, June 06, 2017 8:22 AM > To: Andy Shevchenko <andy.shevche...@gmail.com>; Mani, Rajmohan > <rajmohan.m...@intel.com> > Cc: linux-kernel@vger.kernel.org; linux-g...@vger.kernel.org; linux- > a...@vger.kernel.org; Lee Jones <lee.jo...@linaro.org>; Linus Walleij > <linus.wall...@linaro.org>; Alexandre Courbot <gnu...@gmail.com>; Rafael J. > Wysocki <r...@rjwysocki.net>; Len Brown <l...@kernel.org> > Subject: Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation > region driver > > Hi, > > On 06/06/2017 04:23 PM, Andy Shevchenko wrote: > > +Cc Hans (that's why didn't delete anything from original mail, just > > adding my comments). > > > > Hans, if you have few minutes it would be appreciated to glance on the > > below for some issues if any since you did pass quite a good quest > > with other PMIC drivers. > > I've gone over this driver, nothing stands out in a bad way to me, IOW this > seems like a normal PMIC OpRegion handler to me. >
Thanks for the reviews and time.