On Mon, 9 Apr 2007 13:18:49 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote:
> sysfs is now completely out of driver/module lifetime game. After > deletion, a sysfs node doesn't access anything outside sysfs proper, > so there's no reason to hold onto the attribute owners. Note that > often the wrong modules were accounted for as owners leading to > accessing removed modules. > > This patch kills now unnecessary attribute->owner. Note that with > this change, userland holding a sysfs node does not prevent the > backing module from being unloaded. > > For more info regarding lifetime rule cleanup, please read the > following message. > > http://article.gmane.org/gmane.linux.kernel/510293 > > Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> You missed some s390 attributes :) --- arch/s390/kernel/ipl.c | 2 -- drivers/s390/cio/chp.c | 2 -- drivers/s390/net/qeth_sys.c | 2 +- 3 files changed, 1 insertion(+), 5 deletions(-) --- linux-2.6.orig/arch/s390/kernel/ipl.c +++ linux-2.6/arch/s390/kernel/ipl.c @@ -314,7 +314,6 @@ static struct bin_attribute ipl_paramete .attr = { .name = "binary_parameter", .mode = S_IRUGO, - .owner = THIS_MODULE, }, .size = PAGE_SIZE, .read = &ipl_parameter_read, @@ -338,7 +337,6 @@ static struct bin_attribute ipl_scp_data .attr = { .name = "scp_data", .mode = S_IRUGO, - .owner = THIS_MODULE, }, .size = PAGE_SIZE, .read = &ipl_scp_data_read, --- linux-2.6.orig/drivers/s390/cio/chp.c +++ linux-2.6/drivers/s390/cio/chp.c @@ -165,7 +165,6 @@ static struct bin_attribute chp_measurem .attr = { .name = "measurement_chars", .mode = S_IRUSR, - .owner = THIS_MODULE, }, .size = sizeof(struct cmg_chars), .read = chp_measurement_chars_read, @@ -217,7 +216,6 @@ static struct bin_attribute chp_measurem .attr = { .name = "measurement", .mode = S_IRUSR, - .owner = THIS_MODULE, }, .size = sizeof(struct cmg_entry), .read = chp_measurement_read, --- linux-2.6.orig/drivers/s390/net/qeth_sys.c +++ linux-2.6/drivers/s390/net/qeth_sys.c @@ -993,7 +993,7 @@ static struct attribute_group qeth_osn_d #define QETH_DEVICE_ATTR(_id,_name,_mode,_show,_store) \ struct device_attribute dev_attr_##_id = { \ - .attr = {.name=__stringify(_name), .mode=_mode, .owner=THIS_MODULE },\ + .attr = {.name=__stringify(_name), .mode=_mode, },\ .show = _show, \ .store = _store, \ }; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
