HI Yuval, > -----Original Message----- > From: Mintz, Yuval [mailto:yuval.mi...@cavium.com] > Sent: Saturday, June 10, 2017 1:52 PM > To: Salil Mehta; da...@davemloft.net > Cc: Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); > mehta.salil....@gmail.com; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; Linuxarm > Subject: RE: [PATCH net-next 8/9] net: hns3: Add support of debugfs > interface to HNS3 driver > > > This adds the support of the debugfs interface to the driver for > debugging > > purposes. > > > +const struct hclge_support_cmd support_cmd[] = { > > + {"send cmd", 8, hclge_dbg_send, > > + "opcode flag data0 data1 data2 data3 data4 data5"}, > > + {"help", 4, hclge_dbg_usage, "no option"}, }; > > Is there an actual description of what this does? Or is it simply a > huge backdoor? Yes, I understand it has been coded in haste to assist in debugging of the driver. Yes, there is a format to it but needs bit of work I guess, otherwise it will be like opening pandoras box. For now, I will drop this debugfs patch and later will push with proper explanation of its need and interface.
Thanks Salil
