2017-06-20 12:41 GMT+02:00 Marc Zyngier <[email protected]>: > On 20/06/17 11:31, Bartosz Golaszewski wrote: >> 2017-05-31 18:06 GMT+02:00 Bartosz Golaszewski <[email protected]>: >>> This series is a follow-up to [1]. >>> >>> Some users of irq_alloc_generic_chip() are modules which can be >>> removed (e.g. gpio-ml-ioh) but have no means of freeing the allocated >>> generic chip. >>> >>> Last time it was suggested to provide irq_destroy_generic_chip() which >>> would undo both irq_remove_generic_chip() and irq_alloc_generic_chip(). >>> >>> This functionality is provided by patch 2/5 with 1/5 adding the option >>> to only free the allocated memory. >>> >>> Patch 3/5 exports a function that will be used in the devres variant >>> of irq_alloc_generic_chip(). >>> >>> Patches 4/5 and 5/5 add resource managed versions of >>> irq_alloc_generic_chip() & irq_setup_generic_chip(). They will be used >>> in drivers where applicable. Device resources are released in reverse >>> order so it's ok to call devm_irq_alloc_generic_chip() and then >>> devm_irq_setup_generic_chip(). >>> >>> [1] https://lkml.org/lkml/2017/3/8/550 >>> >>> Bartosz Golaszewski (5): >>> irq: generic-chip: provide irq_free_generic_chip() >>> irq: generic-chip: provide irq_destroy_generic_chip() >>> irq: generic-chip: export irq_init_generic_chip() locally >>> irq: generic-chip: provide devm_irq_alloc_generic_chip() >>> irq: generic-chip: provide devm_irq_setup_generic_chip() >>> >>> Documentation/driver-model/devres.txt | 2 + >>> include/linux/irq.h | 22 +++++++++ >>> kernel/irq/devres.c | 86 >>> +++++++++++++++++++++++++++++++++++ >>> kernel/irq/generic-chip.c | 7 ++- >>> kernel/irq/internals.h | 11 +++++ >>> 5 files changed, 124 insertions(+), 4 deletions(-) >>> >>> -- >>> 2.9.3 >>> >> >> Ping for v4.13. >> >> Is there any reason not to merge it? > > There was a kbuild report from June 1st with worrying warnings on x86_64 > (though I couldn't see how that was related to these patches). What's > the status of that? > > Thanks, > > M. > -- > Jazz is not dead. It just smells funny...
Snap, I looked at it, determined that it was just a header included in include/linux/irq.h (unrelated to the patch) and forgot to comment about it. I've never seen this warning on my setup and don't see it now with rc6. Thanks, Bartosz
