Jay Vosburgh <[email protected]> writes: > Michael J Dilmore <[email protected]> wrote: > >>if (WARN_ON(!new_active_slave) { >> netdev_dbg("Can't add new active slave - pointer null"); >> return ERROR_CODE >>} > > In general, yes, but in this case, the condition should be > impossible to hit, so BUG_ON seems appropriate.
If it really is impossible then you should simply remove the test. No need to test for the impossible, is there? Bjørn
