fs/xattr.c:516:10-17: WARNING opportunity for kstrdep (strcpy on line 519)

 Use kstrdup rather than duplicating its implementation

Generated by: scripts/coccinelle/api/kstrdup.cocci

CC: Stefan Berger <stef...@linux.vnet.ibm.com>
Signed-off-by: Fengguang Wu <fengguang...@intel.com>
---

 xattr.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/fs/xattr.c
+++ b/fs/xattr.c
@@ -513,10 +513,9 @@ xattr_userns_name(const char *fullname,
        return buffer;
 
 out_copy:
-       buffer = kmalloc(strlen(suffix) + 1, GFP_KERNEL);
+       buffer = kstrdup(suffix, GFP_KERNEL);
        if (!buffer)
                return ERR_PTR(-ENOMEM);
-       strcpy(buffer, suffix);
 
        return buffer;
 

Reply via email to