On Sun, Jun 25, 2017 at 08:22:06AM -0400, Tommy Nguyen wrote: > Running coccicheck indicates that DEFINE_DEBUGFS_ATTRIBUTE > and debugfs_create_file_unsafe should be used instead.
Why use the _unsafe version? Are you sure it will work properly? What benifit does it offer? > > Signed-off-by: Tommy Nguyen <[email protected]> > --- > drivers/staging/android/ion/ion.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/android/ion/ion.c > b/drivers/staging/android/ion/ion.c > index 03d3a4f..8f96b38 100644 > --- a/drivers/staging/android/ion/ion.c > +++ b/drivers/staging/android/ion/ion.c > @@ -544,8 +544,8 @@ static int debug_shrink_get(void *data, u64 *val) > return 0; > } > > -DEFINE_SIMPLE_ATTRIBUTE(debug_shrink_fops, debug_shrink_get, > - debug_shrink_set, "%llu\n"); > +DEFINE_DEBUGFS_ATTRIBUTE(debug_shrink_fops, debug_shrink_get, > + debug_shrink_set, "%llu\n"); Are you sure this works? thanks, greg k-h
