On Tue, May 02, 2017 at 09:04:52PM +0800, Wei Yang wrote:
> numa_init() has already called init_func(), which is responsible for
> setting numa_nodes_parsed, so use this nodemask instead of re-finding it
> when calling numa_emulation().
>
> This patch gets the physnode_mask directly from numa_nodes_parsed. At
> the same time, it corrects the comment of these two functions.
>
> Signed-off-by: Wei Yang <richard.weiy...@gmail.com>
> Acked-by: David Rientjes <rient...@google.com>
>
> ---
> v2: refresh the change log based on David Rientjes comment
> ---
> arch/x86/mm/numa_emulation.c | 18 ++++++++----------
> 1 file changed, 8 insertions(+), 10 deletions(-)
>
> diff --git a/arch/x86/mm/numa_emulation.c b/arch/x86/mm/numa_emulation.c
> index eb017c816de6..a6d01931b9a1 100644
> --- a/arch/x86/mm/numa_emulation.c
> +++ b/arch/x86/mm/numa_emulation.c
> @@ -75,13 +75,15 @@ static int __init emu_setup_memblk(struct numa_meminfo
> *ei,
>
> /*
> * Sets up nr_nodes fake nodes interleaved over physical nodes ranging from
> addr
> - * to max_addr. The return value is the number of nodes allocated.
> + * to max_addr.
> + *
> + * Returns zero on success or negative error code.
... on error.
Other than that:
Reviewed-by: Borislav Petkov <b...@suse.de>
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
