On Tue, Jun 27, 2017 at 12:47:59PM -0700, Jacob Pan wrote:
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index d973555..07cfd92 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -48,6 +48,7 @@ struct iommu_group {
> struct list_head devices;
> struct mutex mutex;
> struct blocking_notifier_head notifier;
> + struct blocking_notifier_head fault_notifier;
Do you really need a notifier chain here? Will there ever be more than
one callback registered to it?
> +struct iommu_fault_event {
> + struct device *dev;
Putting a 'struct device *' member in a uapi struct looks fundamentally
wrong.
Joerg
