On Wed 21-06-17 10:57:26, Dou Liyang wrote: > ... initializes local parameters "p_node" & "parent" for > register_node(). > > But, register_node() does not use them. > > Remove the related code of "parent" node, cleanup __register_one_node() > and register_node(). > > Cc: Andrew Morton <[email protected]> > Cc: David Rientjes <[email protected]> > Cc: Michal Hocko <[email protected]> > Cc: [email protected] > Signed-off-by: Dou Liyang <[email protected]> > Acked-by: David Rientjes <[email protected]>
I am sorry, this slipped through cracks. Acked-by: Michal Hocko <[email protected]> > --- > V1 --> V2: > Rebase it on > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm > > drivers/base/node.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/base/node.c b/drivers/base/node.c > index 73d39bc..d8dc830 100644 > --- a/drivers/base/node.c > +++ b/drivers/base/node.c > @@ -288,7 +288,7 @@ static void node_device_release(struct device *dev) > * > * Initialize and register the node device. > */ > -static int register_node(struct node *node, int num, struct node *parent) > +static int register_node(struct node *node, int num) > { > int error; > > @@ -567,19 +567,14 @@ static void init_node_hugetlb_work(int nid) { } > > int __register_one_node(int nid) > { > - int p_node = parent_node(nid); > - struct node *parent = NULL; > int error; > int cpu; > > - if (p_node != nid) > - parent = node_devices[p_node]; > - > node_devices[nid] = kzalloc(sizeof(struct node), GFP_KERNEL); > if (!node_devices[nid]) > return -ENOMEM; > > - error = register_node(node_devices[nid], nid, parent); > + error = register_node(node_devices[nid], nid); > > /* link cpu under this node */ > for_each_present_cpu(cpu) { > -- > 2.5.5 > > > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to [email protected]. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"[email protected]";> [email protected] </a> -- Michal Hocko SUSE Labs
