On Sat, 14 Apr 2007, Ralf Baechle wrote:
> On Sat, Apr 14, 2007 at 12:49:54PM -0400, Robert P. J. Day wrote:
> > Date: Sat, 14 Apr 2007 12:49:54 -0400 (EDT)
> > From: "Robert P. J. Day" <[EMAIL PROTECTED]>
> > To: Linux Kernel Mailing List <[EMAIL PROTECTED]>
> > cc: [EMAIL PROTECTED], Ralf Baechle <[EMAIL PROTECTED]>,
> > [EMAIL PROTECTED]
> > Subject: {Spam?} [PATCH] Remove all traces of legacy power management.
> > Content-Type: TEXT/PLAIN; charset=US-ASCII
> >
> >
> > Remove everything related to legacy power management.
> >
> > Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
>
> > diff --git a/arch/mips/au1000/common/power.c
> > b/arch/mips/au1000/common/power.c
> > index 3901e8e..f3685d6 100644
> > --- a/arch/mips/au1000/common/power.c
> > +++ b/arch/mips/au1000/common/power.c
> > @@ -278,13 +278,11 @@ static int pm_do_sleep(ctl_table * ctl, int write,
> > struct file *file,
> > p = buf;
> > sleep_ticks = simple_strtoul(p, &p, 0);
> > #endif
> > - retval = pm_send_all(PM_SUSPEND, (void *) 2);
> >
> > if (retval)
> > return retval;
> >
> > au_sleep();
> > - retval = pm_send_all(PM_RESUME, (void *) 0);
> > }
> > return retval;
> > }
> > @@ -297,12 +295,10 @@ static int pm_do_suspend(ctl_table * ctl, int write,
> > struct file *file,
> > if (!write) {
> > *len = 0;
> > } else {
> > - retval = pm_send_all(PM_SUSPEND, (void *) 2);
> > if (retval)
> > return retval;
> > suspend_mode = 1;
> >
> > - retval = pm_send_all(PM_RESUME, (void *) 0);
> > }
> > return retval;
> > }
>
> Both segments leave the variable retval as zero initialized and only used
> for the return value ... I'm not sure what these functions actually
> should do - but after your patches they have essentially become glorified
> nops.
ah, good point. feel free to send me a MIPS-specific patch and i can
incorporate it, if you want.
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
