On Fri, Jun 30, 2017 at 06:58:24PM +0300, Andy Shevchenko wrote: > On Fri, Jun 30, 2017 at 6:45 PM, Arnd Bergmann <a...@arndb.de> wrote: > > Marking sony_laptop_input_keycode_map 'const' sounds like a good > > idea in principle, but unfortunately causes a compiler warning: > > > > drivers/platform/x86/sony-laptop.c: In function 'sony_laptop_setup_input': > > drivers/platform/x86/sony-laptop.c:494:19: error: assignment discards > > 'const' qualifier from pointer target type > > [-Werror=discarded-array-qualifiers] > > > > This reverts that part of the previous cleanup patch. > > Thanks, pushed directly to for-next. >
Thanks Andy, > I didn't get a clear result from our 0day kbuild bot, so it was in > testing previously. > > Darren, it looks like we need more clear coordination on what is going > to be applied for-next from testing. Indeed - and my CI build should have caught this warning. I will look into what it's missing so this would be called out as an error. And for this patch, I would prefer to roll this into the original. There is no point in introducing warnings into Linus' kernel. We try not to rebase for-next, but it happens everyday, so it isn't a huge deal for Stephen to deal with. Will you squash it, or shall I? -- Darren Hart VMware Open Source Technology Center
