From: Adrian Hunter <adrian.hun...@intel.com>

Tidy the lookup of the Intel PT selected event (perf_evsel) into a separate
function.

Signed-off-by: Adrian Hunter <adrian.hun...@intel.com>
Cc: Andi Kleen <a...@linux.intel.com>
Link: 
http://lkml.kernel.org/r/1495786658-18063-30-git-send-email-adrian.hun...@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <a...@redhat.com>
---
 tools/perf/util/intel-pt.c | 25 +++++++++++++++----------
 1 file changed, 15 insertions(+), 10 deletions(-)

diff --git a/tools/perf/util/intel-pt.c b/tools/perf/util/intel-pt.c
index b670502b0264..a9486b57584f 100644
--- a/tools/perf/util/intel-pt.c
+++ b/tools/perf/util/intel-pt.c
@@ -1922,24 +1922,29 @@ static int intel_pt_synth_event(struct perf_session 
*session,
                                           &id, intel_pt_event_synth);
 }
 
+static struct perf_evsel *intel_pt_evsel(struct intel_pt *pt,
+                                        struct perf_evlist *evlist)
+{
+       struct perf_evsel *evsel;
+
+       evlist__for_each_entry(evlist, evsel) {
+               if (evsel->attr.type == pt->pmu_type && evsel->ids)
+                       return evsel;
+       }
+
+       return NULL;
+}
+
 static int intel_pt_synth_events(struct intel_pt *pt,
                                 struct perf_session *session)
 {
        struct perf_evlist *evlist = session->evlist;
-       struct perf_evsel *evsel;
+       struct perf_evsel *evsel = intel_pt_evsel(pt, evlist);
        struct perf_event_attr attr;
-       bool found = false;
        u64 id;
        int err;
 
-       evlist__for_each_entry(evlist, evsel) {
-               if (evsel->attr.type == pt->pmu_type && evsel->ids) {
-                       found = true;
-                       break;
-               }
-       }
-
-       if (!found) {
+       if (!evsel) {
                pr_debug("There are no selected events with Intel Processor 
Trace data\n");
                return 0;
        }
-- 
2.9.4

Reply via email to