Hi,
This is mostly fine, even if I'm not too happy with the
s/ck_rtc/rtc_ck/.
On 26/06/2017 at 11:51:29 +0200, Amelie Delaunay wrote:
> - rtc->ck_rtc = devm_clk_get(&pdev->dev, NULL);
> - if (IS_ERR(rtc->ck_rtc)) {
> - dev_err(&pdev->dev, "no ck_rtc clock");
> - return PTR_ERR(rtc->ck_rtc);
> + match = of_match_device(stm32_rtc_of_match, &pdev->dev);
> + if (match && match->data)
> + rtc->data = (struct stm32_rtc_data *)match->data;
> + else
> + return -EINVAL;
This will never happen, you can remove that test.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
