On Mon, 5 Jun 2017 11:31:18 +0200 Federico Vaga <federico.v...@vaga.pv.it> wrote:
> show_file(name) and show_instance_file(&top_instance, name) are > equivalent. > > Remove the show_file() function in order to have a single function for > this task. Actually I find nothing wrong with having a helper function like this. IIRC, show_file() was first, and then show_instance_file() came later. There's some files that only exist for the top_instance, and I like the fact that this is annotated that way. I'm curious to know what the benefit of removing show_file() is? -- Steve > > Signed-off-by: Federico Vaga <federico.v...@vaga.pv.it> > --- > trace-list.c | 21 ++++++--------------- > trace-local.h | 2 -- > trace-show.c | 18 ++---------------- > trace-snapshot.c | 2 +- > 4 files changed, 9 insertions(+), 34 deletions(-) \
