On Sat, 2017-07-08 at 14:24 +0900, Sergey Senozhatsky wrote: > On (07/07/17 11:08), Joe Perches wrote: > > printk.c is a huge file with too many local functions for a > > human to read and easily parse. > > > > Start to separate out bits into smaller files. > > > > Miscellanea: > > > > o Rename suppress_message_printing to printk_suppress_message > > o Add function definitions to printk.h > > I don't mind, in general, but I'm a bit hesitant. we want to have > automatic printk throttling (printk delay basically) and we need > some of those printk-internal *_seq numbers to see how far consoles > are behind the logbuf. so either we need to 'un-static' those *_seq > and extern them in delay.c or simply keep printk-delay machinery in > printk.c and add the new function. > > // p.s. I'll take a look at the patch a bit later. I'm on a sick leave now.
Hey Sergey. Basically, this is a simple trial patch. printk is getting nothing but more complex. I believe printk is in real need of logical separation into multiple parts to isolate the various logic bits. o console o kmsg/devkmsg o logbuf o syslog etc...
