On Mon, 10 Jul 2017 19:03:44 PDT (-0700), rdun...@infradead.org wrote: > On 07/10/2017 07:02 PM, Stephen Rothwell wrote: >> Hi Palmer, >> >> On Mon, 10 Jul 2017 18:39:08 -0700 Palmer Dabbelt <pal...@dabbelt.com> wrote: >>> >>> This patch adds a new copy of these library routine files, which are >>> functionally identical to the various other copies. These are >>> availiable via Kconfig as CONFIG_LIB_$ROUTINE, which currently isn't >> >> Umm, the patch actually uses CONFIG_GENERIC_$ROUTINE. >> >>> +config GENERIC_ASHLDI3 >>> + def_bool n >> >> Just >> bool >> is the same. >> > > and several "default n" lines can (should) be removed from Kconfig.
I'm not much of a Kconfig hacker... How does this look? commit 4aaad1e6e8a70020dd95b8a13a4075af97cb858f Author: Palmer Dabbelt <pal...@dabbelt.com> Date: Mon Jul 10 19:07:43 2017 -0700 lib: Remove "default n" lines from Kconfig These lines aren't necessary, as the default is "n" anyway. Signed-off-by: Palmer Dabbelt <pal...@dabbelt.com> diff --git a/lib/Kconfig b/lib/Kconfig index ee7d8bf0b7e1..78dec2408481 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -15,7 +15,6 @@ config BITREVERSE config HAVE_ARCH_BITREVERSE bool - default n depends on BITREVERSE help This option enables the use of hardware bit-reversal instructions on @@ -48,7 +47,6 @@ config GENERIC_IOMAP config GENERIC_IO bool - default n config STMP_DEVICE bool @@ -199,7 +197,6 @@ config AUDIT_GENERIC config AUDIT_ARCH_COMPAT_GENERIC bool - default n config AUDIT_COMPAT_GENERIC bool @@ -208,7 +205,6 @@ config AUDIT_COMPAT_GENERIC config RANDOM32_SELFTEST bool "PRNG perform self test on init" - default n help This option enables the 32 bit PRNG library functions to perform a self test on initialization. @@ -405,12 +401,10 @@ config HAS_DMA config DMA_NOOP_OPS bool depends on HAS_DMA && (!64BIT || ARCH_DMA_ADDR_T_64BIT) - default n config DMA_VIRT_OPS bool depends on HAS_DMA && (!64BIT || ARCH_DMA_ADDR_T_64BIT) - default n config CHECK_SIGNATURE bool