On Wed, Jul 12, 2017 at 07:46:42PM +0200, Peter Zijlstra wrote: > On Wed, Jul 12, 2017 at 08:56:51AM -0700, Paul E. McKenney wrote: > > Very good, I have queued the patch below. I left out the removal of > > the export as I need to work out why the export was there. If it turns > > out not to be needed, I will remove the related ones as well. > > 'git grep rcu_idle_enter' shows no callers other than > kernel/sched/idle.c. Which seems a clear indication its not needed. > > You also have to ask yourself, do I want joe module author to ever call > this. To which I suspect the answer is: hell no ;-)
The other question is "why did I do this in the first place". The only case where there will turn out to have been a still-valid reason is if I remove it without checking first. ;-) Thanx, Paul