On 07/13, Florian Fainelli wrote: > On 07/13/2017 07:02 AM, [email protected] wrote: > > From: Gabriel Fernandez <[email protected]> > > > > This patch exposes clk_gate_ops::is_enabled as functions > > that can be directly called and assigned in places like this so > > we don't need wrapper functions that do nothing besides forward > > the call. > > > > Signed-off-by: Gabriel Fernandez <[email protected]> > > Sugested by Stephen Boyd <[email protected]> > > --- > > drivers/clk/clk-gate.c | 2 +- > > include/linux/clk-provider.h | 1 + > > 2 files changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/clk/clk-gate.c b/drivers/clk/clk-gate.c > > index 4e0c054a..e27e28f 100644 > > --- a/drivers/clk/clk-gate.c > > +++ b/drivers/clk/clk-gate.c > > @@ -86,7 +86,7 @@ static void clk_gate_disable(struct clk_hw *hw) > > clk_gate_endisable(hw, 0); > > } > > > > -static int clk_gate_is_enabled(struct clk_hw *hw) > > +int clk_gate_is_enabled(struct clk_hw *hw) > > { > > u32 reg; > > struct clk_gate *gate = to_clk_gate(hw); > > Don't you need to add an EXPORT_SYMBOL_GPL(clk_gate_is_enabled) as well > in case this gets used by modules?
It would be needed in the future if someone uses it from a module. The only user in this patch series looks to be builtin only. I can add it when applying the patch if there aren't other comments on the series. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
