> + down_write(&nvmet_config_sem); > subsys->ver = NVME_VS(1, 3, 0); /* NVMe 1.3.0 */ > /* generate a random serial number as our controllers are ephemeral: */ > get_random_bytes(&subsys->serial, sizeof(subsys->serial)); > + up_write(&nvmet_config_sem);
no need for the lock here, the subsystems isn't visible at this point. Otherwise: Reviewed-by: Christoph Hellwig <h...@lst.de>
