On Thu, 04 May 2017, Julia Lawall wrote: > Drop static on a local variable, when the variable is initialized before > any use, on every possible execution path through the function. > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @bad exists@ > position p; > identifier x; > type T; > @@ > > static T x@p; > ... > x = <+...x...+> > > @@ > identifier x; > expression e; > type T; > position p != bad.p; > @@ > > -static > T x@p; > ... when != x > when strict > ?x = e; > // </smpl> > > The change increases the code size but decreases the size of the bss segment. > > before: > text data bss dec hex filename > 3369 272 300 3941 f65 drivers/mfd/twl4030-irq.o > > after: > text data bss dec hex filename > 3401 272 28 3701 e75 drivers/mfd/twl4030-irq.o > > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> > > --- > drivers/mfd/twl4030-irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
