Am Dienstag, 18. Juli 2017, 11:02:02 CEST schrieb Arnd Bergmann: Hi Arnd, > > I can see why the jitterentropy implementation avoids using kernel headers, > the problem now is that part of it gets moved into a new header, and that > already violates the original principle. > > From my reading of the code, we could probably leave the structure > definition in the crypto/jitterentropy.c, and have the statically > allocated instance in the same file when CONFIG_LRNG is > set,
That is a very good idea -- I will implement this approach. > or provide a way to allocate an instance early (I assume you > can't call jent_entropy_collector_alloc() here since you need > the RNG long before kzalloc() works). Correct. I cannot assume that any of the memory allocation routines are available. Thank you. Ciao Stephan
