On 18/07/17 16:55, Viresh Kumar wrote: > On 18-07-17, 12:20, Juri Lelli wrote: > > Hi Viresh, > > > > On 18/07/17 10:24, Viresh Kumar wrote:
[...] > > > > It actually belongs here, IMHO. We update other fields (util, max, > > flags) > > Yeah, because they have bigger roles and aren't specific to iowait > boost. > > > before looking at iowait. Why hiding the time update into a > > function dealing with only one of such fields? > > But last_update is very much specific to iowait_boost only and so it > should be updated from sugov_set_iowait_boost() IMHO. > Huh, I see you point. However, I'm using it also to deal with stale CFS util values in my patches [1]. Sure, not mainline yet, but I guess I'll have to sort of revert your proposed change for my next version. Or think of a better idea. :) Thanks, - Juri [1] http://marc.info/?l=linux-kernel&m=149924526528298&w=2
