Commit-ID: acc80c39929b9f2ff8b45fcfe103385a3e45c1a7 Gitweb: http://git.kernel.org/tip/acc80c39929b9f2ff8b45fcfe103385a3e45c1a7 Author: Julia Lawall <julia.law...@lip6.fr> AuthorDate: Sat, 15 Jul 2017 22:07:45 +0200 Committer: Thomas Gleixner <t...@linutronix.de> CommitDate: Tue, 18 Jul 2017 21:59:23 +0200
irqchip/digicolor: Drop unnecessary static Drop static on a local variable, when the variable is initialized before any possible use. Thus, the static has no benefit. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @bad exists@ position p; identifier x; type T; @@ static T x@p; ... x = <+...x...+> @@ identifier x; expression e; type T; position p != bad.p; @@ -static T x@p; ... when != x when strict ?x = e; // </smpl> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Thomas Gleixner <t...@linutronix.de> Acked-by: Baruch Siach <bar...@tkos.co.il> Cc: keesc...@chromium.org Cc: Marc Zyngier <marc.zyng...@arm.com> Cc: kernel-janit...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Cc: Jason Cooper <ja...@lakedaemon.net> Link: http://lkml.kernel.org/r/1500149266-32357-11-git-send-email-julia.law...@lip6.fr --- drivers/irqchip/irq-digicolor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-digicolor.c b/drivers/irqchip/irq-digicolor.c index dad85e7..3aae015 100644 --- a/drivers/irqchip/irq-digicolor.c +++ b/drivers/irqchip/irq-digicolor.c @@ -71,7 +71,7 @@ static void __init digicolor_set_gc(void __iomem *reg_base, unsigned irq_base, static int __init digicolor_of_init(struct device_node *node, struct device_node *parent) { - static void __iomem *reg_base; + void __iomem *reg_base; unsigned int clr = IRQ_NOREQUEST | IRQ_NOPROBE | IRQ_NOAUTOEN; struct regmap *ucregs; int ret;
