On Tue, Jul 18, 2017 at 04:42:41PM -0500, Rob Herring wrote: > Now that we have a custom printf format specifier, convert users of > full_name to use %pOF instead. This is preparation to remove storing
Oh nice. If the commit adding %pOF is already set in stone, i'd suggest to mention the commit id here in the commit log. > of the full path string for each node. > > Signed-off-by: Rob Herring <[email protected]> > Cc: Russell King <[email protected]> > Cc: Kukjin Kim <[email protected]> > Cc: Krzysztof Kozlowski <[email protected]> > Cc: Javier Martinez Canillas <[email protected]> > Cc: Shawn Guo <[email protected]> > Cc: Sascha Hauer <[email protected]> > Cc: Fabio Estevam <[email protected]> > Cc: Jason Cooper <[email protected]> > Cc: Andrew Lunn <[email protected]> > Cc: Gregory Clement <[email protected]> > Cc: Sebastian Hesselbarth <[email protected]> > Cc: Tony Lindgren <[email protected]> > Cc: "Benoît Cousson" <[email protected]> > Cc: Paul Walmsley <[email protected]> > Cc: Heiko Stuebner <[email protected]> > Cc: Simon Horman <[email protected]> > Cc: Magnus Damm <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > --- > arch/arm/kernel/cpuidle.c | 4 ++-- > arch/arm/kernel/devtree.c | 6 +++--- > arch/arm/kernel/topology.c | 4 ++-- > arch/arm/mach-exynos/suspend.c | 8 ++++---- > arch/arm/mach-imx/gpc.c | 4 ++-- > arch/arm/mach-mvebu/kirkwood.c | 4 ++-- > arch/arm/mach-omap2/omap-wakeupgen.c | 4 ++-- > arch/arm/mach-omap2/omap_hwmod.c | 4 ++-- > arch/arm/mach-rockchip/platsmp.c | 4 ++-- > arch/arm/mach-shmobile/pm-rmobile.c | 8 ++++---- > 10 files changed, 25 insertions(+), 25 deletions(-) > > diff --git a/arch/arm/kernel/cpuidle.c b/arch/arm/kernel/cpuidle.c > index a3308ad1a024..fda5579123a8 100644 > --- a/arch/arm/kernel/cpuidle.c > +++ b/arch/arm/kernel/cpuidle.c > @@ -101,8 +101,8 @@ static int __init arm_cpuidle_read_ops(struct device_node > *dn, int cpu) > > ops = arm_cpuidle_get_ops(enable_method); > if (!ops) { > - pr_warn("%s: unsupported enable-method property: %s\n", > - dn->full_name, enable_method); > + pr_warn("%pOF: unsupported enable-method property: %s\n", > + dn, enable_method); > return -EOPNOTSUPP; > } > > diff --git a/arch/arm/kernel/devtree.c b/arch/arm/kernel/devtree.c > index f676febbb270..28174c9a94ac 100644 > --- a/arch/arm/kernel/devtree.c > +++ b/arch/arm/kernel/devtree.c > @@ -95,7 +95,7 @@ void __init arm_dt_init_cpu_maps(void) > if (of_node_cmp(cpu->type, "cpu")) > continue; > > - pr_debug(" * %s...\n", cpu->full_name); > + pr_debug(" * %pOF...\n", cpu); > /* > * A device tree containing CPU nodes with missing "reg" > * properties is considered invalid to build the > @@ -103,8 +103,8 @@ void __init arm_dt_init_cpu_maps(void) > */ > cell = of_get_property(cpu, "reg", &prop_bytes); > if (!cell || prop_bytes < sizeof(*cell)) { > - pr_debug(" * %s missing reg property\n", > - cpu->full_name); > + pr_debug(" * %pOF missing reg property\n", > + cpu); You could join lines here and in the next hunk. And there are two more further down. > of_node_put(cpu); > return; > } > diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c > index bf949a763dbe..e596c5b8f931 100644 > --- a/arch/arm/kernel/topology.c > +++ b/arch/arm/kernel/topology.c > @@ -127,8 +127,8 @@ static void __init parse_dt_topology(void) > > rate = of_get_property(cn, "clock-frequency", &len); > if (!rate || len != 4) { > - pr_err("%s missing clock-frequency property\n", > - cn->full_name); > + pr_err("%pOF missing clock-frequency property\n", > + cn); > continue; > } > Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
