Re: [PATCH] watchdog: imx2_wdt: use new_timeout value to override the old

[Guenter Roeck]

On 07/19/2017 07:45 PM, yanjiang....@windriver.com wrote:

From: Yanjiang Jin <yanjiang....@windriver.com>

Without this patch we couldn't change the timeout value of imx2_wdt.

Signed-off-by: Yanjiang Jin <yanjiang....@windriver.com>
---
  drivers/watchdog/imx2_wdt.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c
index 4874b0f..6cfeee6 100644
--- a/drivers/watchdog/imx2_wdt.c
+++ b/drivers/watchdog/imx2_wdt.c
@@ -178,6 +178,9 @@ static int imx2_wdt_set_timeout(struct watchdog_device 
*wdog,

regmap_update_bits(wdev->regmap, IMX2_WDT_WCR, IMX2_WDT_WCR_WT,

                           WDOG_SEC_TO_COUNT(new_timeout));
+
+       wdog->timeout = new_timeout;
+

I must be missing something. That very same code is already in line 177,
added with commit 30dd4a8f08b57 ("watchdog: imx2_wdt: also set wdog->timeout
to new_timeout") back in 2015.

Did you see this in an older kernel, maybe ?

Guenter