On Thu, Jul 20, 2017 at 12:04:01PM +0100, Punit Agrawal wrote:
> When booting an ACPI enabled system that does not provide the hardware
> error source table (HEST), the ghes driver prints the following message
> in the kernel log -
>
> [ 3.460067] GHES: HEST is not enabled!
>
> which is not helpful.
>
> The message is also output when HEST is explicitly disabled using kernel
> command line parameter.
>
> Drop this message. While we are touching this code, also drop similar
> message when GHES is disabled using the module parameter.
No.
To the contrary, we want to know *why* GHES/HEST doesn't get enabled when
booting. See
dba648300e89 ("ACPI / einj: Make error paths more talkative")
for a good example why.
If anything, you should do the total opposite patch and add more
printks to the error paths so that it is obvious why GHES startup fails.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284
(AG Nürnberg)
--
