Hi! > > Kernel config options should include useful help text; I had to look > > up the terms on wikipedia. > > > > Signed-off-by: Pavel Machek <[email protected]> > > > > diff --git a/net/bluetooth/Kconfig b/net/bluetooth/Kconfig > > index 68f951b..133c8a6 100644 > > --- a/net/bluetooth/Kconfig > > +++ b/net/bluetooth/Kconfig > > @@ -45,6 +45,8 @@ config BT_BREDR > > bool "Bluetooth Classic (BR/EDR) features" > > depends on BT > > default y > > + help > > + Support Bluetooth version 1 and 2 connections. > > so this is actually not correct. Version 5.0 is also Bluetooth BR/EDR. > > I am fine if use the terms "Basic Rate" and "Enhanced Data Rate" in the > description, but the version numbers are kinda not how this works. So some > alternative wording needs to be used: > > "Bluetooth Classic includes support for Basic Rate (BR) available with > Bluetooth version 1.0b or later and support for Enhanced Data Rate (EDR) > available with Bluetooth version 2.0 or later." >
Ok, works for me.
> > + help
> > + Bluetooth 3 introduces high-speed mode where bluetooth endpoints
> > + negotiate fast connection over WIFI. This controls its support.
>
> Again, while Bluetooth version 3.0 introduces HS support, it is not what is
> selecting this.
>
> I think here we can write something like this:
>
> "Bluetooth High Speed includes support for off-loading Bluetooth connections
> via 802.11 physical layer available with Bluetooth version 3.0 or later."
>
Ok.
> > config BT_LE
> > bool "Bluetooth Low Energy (LE) features"
> > depends on BT
> > default y
> > + help
> > + Bluetooth 4 introduces special low-energy protocol, designed
> > + for simple devices. This controls its support.
>
> I think here it is also better to have an alternative text:
>
> "Bluetooth Low Energy includes support low-energy physical layer available
> with Bluetooth version 4.0 or later."
>
Ok. Do I understand it correctly that Bluetooth LE basically has
nothing to do with bluetooth, and that Bluetooth 2 hardware will not
be able to detect / communicate with Bluetooth LE hardware?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
