From: Andi Kleen <a...@linux.intel.com>

Today, when a JSON file fails parsing the build continues,
but there are no json files built in, which is difficult to debug later.
Make the build stop on a parse error instead.

Cc: suka...@linux.vnet.ibm.com
Signed-off-by: Andi Kleen <a...@linux.intel.com>
---
 tools/perf/pmu-events/jevents.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
index 70cbd5bc4819..58b42508c333 100644
--- a/tools/perf/pmu-events/jevents.c
+++ b/tools/perf/pmu-events/jevents.c
@@ -890,6 +890,9 @@ int main(int argc, char *argv[])
        if (rc && verbose) {
                pr_info("%s: Error walking file tree %s\n", prog, ldirname);
                goto empty_map;
+       } else if (rc < 0) {
+               /* Make build fail */
+               return 1;
        } else if (rc) {
                goto empty_map;
        }
@@ -904,7 +907,8 @@ int main(int argc, char *argv[])
 
        if (process_mapfile(eventsfp, mapfile)) {
                pr_info("%s: Error processing mapfile %s\n", prog, mapfile);
-               goto empty_map;
+               /* Make build fail */
+               return 1;
        }
 
        return 0;
-- 
2.9.4

Reply via email to