On Sun, 2017-07-23 at 12:54 +0300, Andy Shevchenko wrote:
> On Sun, Jul 23, 2017 at 4:15 AM, Lyude <[email protected]> wrote:
>
> > So, call hid_hw_open() in rmi_post_resume() so we make sure that
> > the
> > device is alive before we try talking to it.
> >
> > This fixes RMI device suspend/resume over HID.
> > - int ret;
> > + int ret = 0;
>
> What's the point?
So that we can use the same out: label at the end of the function that
calls hid_hw_close() to return success. This being said though I just
realized that setting ret will initialize it to 0 anyway, so I guess
this can be dropped
>
> >
> > if (!(data->device_flags & RMI_DEVICE))
> > return 0;
> >
> > - ret = rmi_reset_attn_mode(hdev);
> > + /* Make sure the HID device is ready to receive events */
> > + ret = hid_hw_open(hdev);
> > if (ret)
> > return ret;
>
>
