On Thu, Apr 19, 2007 at 12:10:34PM -0700, Christoph Lameter wrote: > Variable Order Page Cache: Add functions to establish sizes > > We use the macros PAGE_CACHE_SIZE PAGE_CACHE_SHIFT PAGE_CACHE_MASK > and PAGE_CACHE_ALIGN in various places in the kernel. These are now > the base page size but we do not have a means to calculating these > values for higher order pages. > > Provide these functions. An address_space pointer must be passed > to them. > > New function Related base page constant > --------------------------------------------------- > page_cache_shift(a) PAGE_CACHE_SHIFT > page_cache_size(a) PAGE_CACHE_SIZE > page_cache_mask(a) PAGE_CACHE_MASK > page_cache_align(addr,a) PAGE_CACHE_ALIGN(addr)
I think PAGE_CACHE_SIZE is a redundant define with these modifications. The page cache size in now variable and it is based on a multiple of PAGE_SIZE. Hence I suggest that PAGE_CACHE_SIZE and it's derivitives should be made to go away completely with this change. Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
