Re: [PATCH] net: inet: diag: expose sockets cgroup classid

[Cong Wang]

On Wed, Jul 26, 2017 at 10:22 AM, Levin, Alexander (Sasha Levin)
<alexander.le...@verizon.com> wrote:
> +       if (ext & (1 << (INET_DIAG_CLASS_ID - 1))) {
> +               u32 classid = 0;
> +
> +#ifdef CONFIG_SOCK_CGROUP_DATA
> +               classid = sock_cgroup_classid(&sk->sk_cgrp_data);
> +#endif


If CONFIG_SOCK_CGROUP_DATA is not enabled, should we put 0
or put nothing (that is, skipping this nla_put())?

> +
> +               nla_put(skb, INET_DIAG_CLASS_ID, sizeof(classid), &classid);

nla_put_u32()

Thanks.