Re: [PATCH 08/14] ipmi: use atomic_dec_not_zero()

[Corey Minyard]

I missed this until now, and I see it hasn't been applied yet.  It's 
queued for the next release.

Thanks,
-corey

On 01/30/2017 12:47 PM, Fabian Frederick wrote:
instead of atomic_add_unless(value, -1, 0)

Signed-off-by: Fabian Frederick <f...@skynet.be>
---
  drivers/char/ipmi/ipmi_msghandler.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/ipmi/ipmi_msghandler.c 
b/drivers/char/ipmi/ipmi_msghandler.c
index 9f69995..961d677 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -3851,7 +3851,7 @@ static void handle_new_recv_msgs(ipmi_smi_t intf)
         * If the pretimout count is non-zero, decrement one from it and
         * deliver pretimeouts to all the users.
         */
-       if (atomic_add_unless(&intf->watchdog_pretimeouts_to_deliver, -1, 0)) {
+       if (atomic_dec_not_zero(&intf->watchdog_pretimeouts_to_deliver)) {
                ipmi_user_t user;
  
  		rcu_read_lock();