Hi Ryder,

[auto build test WARNING on tj-libata/for-next]
[also build test WARNING on v4.13-rc2 next-20170728]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Ryder-Lee/Add-support-for-MediaTek-AHCI-SATA/20170728-164513
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tj/libata.git for-next
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget 
https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm64 

All warnings (new ones prefixed by >>):

   drivers/ata/ahci_mtk.c: In function 'mtk_ahci_platform_resets':
>> drivers/ata/ahci_mtk.c:60:32: warning: comparison of constant '-517' with 
>> boolean expression is always false [-Wbool-compare]
     if (IS_ERR(drv_data->axi_rst) == -EPROBE_DEFER)
                                   ^~
   drivers/ata/ahci_mtk.c:64:31: warning: comparison of constant '-517' with 
boolean expression is always false [-Wbool-compare]
     if (IS_ERR(drv_data->sw_rst) == -EPROBE_DEFER)
                                  ^~
   drivers/ata/ahci_mtk.c:68:32: warning: comparison of constant '-517' with 
boolean expression is always false [-Wbool-compare]
     if (IS_ERR(drv_data->reg_rst) == -EPROBE_DEFER)
                                   ^~
>> drivers/ata/ahci_mtk.c:60:6: warning: ignoring return value of 'IS_ERR', 
>> declared with attribute warn_unused_result [-Wunused-result]
     if (IS_ERR(drv_data->axi_rst) == -EPROBE_DEFER)
         ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/ata/ahci_mtk.c:64:6: warning: ignoring return value of 'IS_ERR', 
declared with attribute warn_unused_result [-Wunused-result]
     if (IS_ERR(drv_data->sw_rst) == -EPROBE_DEFER)
         ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/ata/ahci_mtk.c:68:6: warning: ignoring return value of 'IS_ERR', 
declared with attribute warn_unused_result [-Wunused-result]
     if (IS_ERR(drv_data->reg_rst) == -EPROBE_DEFER)
         ^~~~~~~~~~~~~~~~~~~~~~~~~

vim +60 drivers/ata/ahci_mtk.c

    51  
    52  static int mtk_ahci_platform_resets(struct ahci_host_priv *hpriv,
    53                                      struct device *dev)
    54  {
    55          struct mtk_ahci_drv_data *drv_data = hpriv->plat_data;
    56          int err;
    57  
    58          /* reset AXI bus and phy part */
    59          drv_data->axi_rst = devm_reset_control_get_optional(dev, 
"axi-rst");
  > 60          if (IS_ERR(drv_data->axi_rst) == -EPROBE_DEFER)
    61                  return -EPROBE_DEFER;
    62  
    63          drv_data->sw_rst = devm_reset_control_get_optional(dev, 
"sw-rst");
    64          if (IS_ERR(drv_data->sw_rst) == -EPROBE_DEFER)
    65                  return -EPROBE_DEFER;
    66  
    67          drv_data->reg_rst = devm_reset_control_get_optional(dev, 
"reg-rst");
    68          if (IS_ERR(drv_data->reg_rst) == -EPROBE_DEFER)
    69                  return -EPROBE_DEFER;
    70  
    71          err = reset_control_assert(drv_data->axi_rst);
    72          if (err) {
    73                  dev_err(dev, "assert axi bus failed\n");
    74                  return err;
    75          }
    76  
    77          err = reset_control_assert(drv_data->sw_rst);
    78          if (err) {
    79                  dev_err(dev, "assert phy digital part failed\n");
    80                  return err;
    81          }
    82  
    83          err = reset_control_assert(drv_data->reg_rst);
    84          if (err) {
    85                  dev_err(dev, "assert phy register part failed\n");
    86                  return err;
    87          }
    88  
    89          err = reset_control_deassert(drv_data->reg_rst);
    90          if (err) {
    91                  dev_err(dev, "deassert phy register part failed\n");
    92                  return err;
    93          }
    94  
    95          err = reset_control_deassert(drv_data->sw_rst);
    96          if (err) {
    97                  dev_err(dev, "deassert phy digital part failed\n");
    98                  return err;
    99          }
   100  
   101          err = reset_control_deassert(drv_data->axi_rst);
   102          if (err) {
   103                  dev_err(dev, "deassert axi bus failed\n");
   104                  return err;
   105          }
   106  
   107          return 0;
   108  }
   109  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to